-
Notifications
You must be signed in to change notification settings - Fork 0
feat(databases): Add databases run command for and isolated database CLI #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4307ff6
feat: add database_session (mint/refresh/persist database-scoped JWT)
pthurlow 69bb627
docs(database_session): annotate dead_code rationale + session_from_r…
pthurlow ead49ca
feat: databases run mint + auto-create helpers
pthurlow e973d85
test/docs(databases run): assert create body + clarify no current-db …
pthurlow f1383e1
feat: wire 'databases run' clap subcommand + dispatch
pthurlow bd67b14
docs(databases run): match Create's schema/expires_at help text
pthurlow eb2bbf0
chore(database_session): silence dead_code warnings on the reserved r…
pthurlow 30bc4ef
feat(databases run): accept group-positional <id>, mirroring sandbox run
pthurlow 447c349
docs: document 'databases run' in README and hotdata SKILL
pthurlow cceb97d
feat(databases run): child ApiClient consumes HOTDATA_DATABASE_TOKEN …
pthurlow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: this user-facing flag is
--descriptionbutdatabases create(line 571) uses--namefor the same underlying JSON field — both end up serialized as"name"bycreate_database_request. Two different flag names for the same field on sibling subcommands will trip people up. Picking one (and aligning README/SKILL.md, which currently disagree about which is canonical) would be worth a follow-up. (not blocking)