Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uniqueItemsnormalizes booleans usingstr(), makingtruecollide with the JSON string"True"(andfalsewith"False"). Valid arrays such as[true, "True"]therefore fail validation. The same collision occurs inside nested arrays and objects.Use a type-tagged boolean value in the existing normalization function. This keeps booleans distinct from strings and numbers while equal boolean values still compare equal. Regression tests cover both booleans, nested arrays/objects, and numeric distinction controls under drafts 04, 06 and 07.
Validation: 18 new cases fail before the change; the complete non-benchmark suite passes after it (625 passed, 4 skipped, 12 deselected) on Python 3.13. Pylint 4.1 reports the same nine diagnostics and 9.90/10 score as an untouched checkout;
git diff --checkpasses.