fix(ingo): remove deprecated V3 form shims in vacation/spam forms - #37
Merged
Merged
Conversation
Horde_Form\V3\BaseVariable::getInfo() now logs a deprecation warning whenever a second argument is passed, since the $info parameter is ignored after the Type/Variable merge in the V3 form migration. Ingo_Form_Vacation::validate() was still passing an unused empty array, spamming the log on every vacation form validation.
The legacy Horde_Form_Variable/Horde_Form_Type split was merged into a single Horde\Form\V3\BaseVariable class. Reaching through the compatibility shim's ->type accessor now logs a deprecation warning on every access. Ingo_Basic_Spam and Ingo_Form_Spam still used this indirection to call setFolder() and set newFolderSet on the folder variable; both now operate directly on the variable object, which __get(type) already resolved to.
ralflang
added a commit
that referenced
this pull request
Jul 18, 2026
Release version 4.0.1 Merge pull request #38 from horde/fix/unserialize-mail-allowed-classes test(storage): extend Ingo_Unit_TestBase in unserialize test fix(storage): allow nested mail classes in rule unserialize Merge pull request #37 from horde/fix/form-v3-deprecation-warnings fix(ingo): remove deprecated ->type indirection in spam form fix(ingo): remove deprecated getInfo() $info argument in vacation form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNlog noise introduced by the V3 form migration, with no functional behavior change.Motivation
With the
lib/→src/V3/form migration,Horde_Form_VariableandHorde_Form_Typewere merged into a singleHorde\Form\V3\BaseVariableclass. Two backward-compatibility shims now log a deprecation warning on every use:getInfo($vars, $info)— the second$infoargument is ignored and warns if passed.->type— accessing this legacy property returns$thisand warns.Two Ingo call sites still used the deprecated shapes, spamming
horde.logon every vacation-form validation and every load of the spam-filtering page.Changes
Ingo_Form_Vacation::validate(): callgetInfo($vars)without the unused second argument.Ingo_Basic_Spam::_init()/Ingo_Form_Spam::validate(): callsetFolder()/ setnewFolderSetdirectly onfolder_varinstead of through the deprecated->typeaccessor (which already just returned the same object).Test plan
Variable property 'type' is deprecated/getInfo() ... $info ... deprecatedwarnings no longer appear in the log for these code paths.