Skip to content

feat: extraVolumes and extraVolumeMounts for the celld pod - #22

Merged
patrickleet merged 1 commit into
mainfrom
feat/extra-volumes
Oct 23, 2026
Merged

patrickleet merged 1 commit into
mainfrom
feat/extra-volumes

Conversation

@patrickleet

@patrickleet patrickleet commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Adds extraVolumes (pod) and extraVolumeMounts (celld container), defaulting to empty, so deployments can mount files such as a private CA bundle for outbound TLS. celld 0.6.2 reads SSL_CERT_FILE in addition to its public roots (verified with a celld dev probe worker fetching a Dory-CA-signed host).

Needed for Mob Pit on Hops local (hops-ops/distributed#291): celld's outbox Queue relay is HTTPS-only, and in kind-hops the services present a cert from a local CA.

helm template renders unchanged with defaults; with the values in the README example it mounts the secret and sets the env; helm lint passes.

Summary by CodeRabbit

  • New Features
    • Added support for mounting additional volumes and volume mounts in the celld pod, including private CA certificates.
    • Documented how to configure a private CA certificate and set SSL_CERT_FILE.

Lets the celld container mount files such as a private CA bundle for
outbound TLS (SSL_CERT_FILE), next to extraEnv/extraEnvFrom.
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f971c947-ac27-4a20-b18e-dace76ac6d1f
📥 Commits

Reviewing files that changed from the base of the PR and between e4e1637 and c27e11a.

📒 Files selected for processing: 3
  • README.md
  • templates/statefulset.yaml
  • values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The chart now supports additional pod volumes and celld container mounts. The README includes an example that mounts a private CA secret and sets SSL_CERT_FILE.

Changes: Pod volume configuration

Layer / File(s) Summary
Configure and render extra volumes and mounts
values.yaml, templates/statefulset.yaml, README.md
values.yaml defines empty defaults for extra volumes and mounts. The StatefulSet renders each section when configured. The README shows a private CA secret mount and the SSL_CERT_FILE setting.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to c27e1

The added volume and mount configuration is mergeable with no identified material risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the addition of extraVolumes and extraVolumeMounts for the celld pod, which is the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet
patrickleet merged commit 694a329 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant