Repository navigation
fix(admin): enforce the declared first-release server floor - #321
Merged
Merged
Conversation
MINIMUM_SUPPORTED_SERVER_VERSION was 1.0.0, a number no capability introduced, while release/sdk-capability-baseline.json declares first-release. honua-release#233 maps a first-release baseline to 2026.1.0-0, the least SemVer identity of the first server release line; the JS and .NET SDKs carry the same value. Candidates (2026.1.0-rc.N), the release (2026.1.1 as the server reports it) and later servers pass. Builds from before honua-server#4693 gave the server a version identity report 1.0.0+<sha>; they are not release identities and are now refused, which reverses the #219 matrix case on purpose. test_server_floor_baseline.py fails when the constant, the server matrix baseline or docs/compatibility.md disagrees with the baseline file. The public API snapshot carries the new constant and default.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex security review |
11 of 21 tasks
4 of 5 tasks
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Admin client still accepts servers below its declared first-release baseline. Set its minimum to
2026.1.0-0, align the public API snapshot, compatibility matrix and documentation, and verify that they stay consistent withrelease/sdk-capability-baseline.json. Earlier assembly-default server identities now receive a truthful refusal; first-release candidates and releases remain supported.Reuses the existing
fix/233-runtime-server-floorimplementation and integrates current trunk9365a940a0c3eb3ceb98b9d5fed33b66829a5729. This completes the Python source companion to honua-io/honua-release#774 and honua-sdk-dotnet#457; JS delivery is honua-sdk-js#2228. PyPI publication and actual installed-package compatibility acceptance remain outstanding.Validation used an isolated Python 3.12 environment installed from the hash-checked CI dependency lock: full Ruff lint, generated sync-client drift checks, strict mypy, all 297 Admin/compatibility-gate tests, and the public API/protocol-factory/server-matrix compatibility gate passed. The original source and verification harness remained unchanged throughout. No live-server or release-tier certification is claimed.
Refs honua-io/honua-release#233
Refs honua-io/honua-release#883