Spring 2026 Update by NorthernMan54 · Pull Request #62 · homebridge/node-pty-prebuilt-multiarch

NorthernMan54 · 2025-07-06T04:50:37Z

Changes

Added support for Windows ARM, and shipping support for NodeJS 20, 21, 22, 23, 24, and 25
Added support for NodeJS 25

Breaking Change

Support for NodeJS 17 and 18 has been removed

…er than 20

Copilot

Pull Request Overview

This PR streamlines the build pipeline, drops legacy Debian 9 support, and adds Windows ARM64 build support.

Bumps package version and Node engine requirement to 20+
Removes the old Debian Dockerfile and tweaks Alpine build to constrain JOBS
Updates GitHub workflows to include Windows ARM runners and refactors the build matrix

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
package.json	Version bump to 0.14.1 and requires Node ≥20.0.0
.prebuild/Dockerfile.oldDebian	Removed outdated Debian 9 build recipe
.prebuild/Dockerfile.alpine	Added `ENV JOBS=1` to limit parallelism
.npmignore	Ignoring `deps/` and `src/` to match published files
.github/workflows/Stage 2 - Validate.yml	Expanded OS matrix (including Windows ARM), adjusted branches
.github/workflows/Prepare prebuild environment.yml	Updated node targets and added Windows ARM prebuild step
.github/workflows/Alternate Approach.yml	Refactored matrix for multi-platform builds and simplified steps

Comments suppressed due to low confidence (5)

package.json:55

Bumping the engines field to Node >=20 drops support for Node 18 and 19; please confirm this breaking change is intended or provide compatibility notes.

    "node": ">=20.0.0 <25.0.0"

.github/workflows/Alternate Approach.yml:126

The --platform flag was removed from the docker build command, which may cause incorrect builds on non-native targets. Reintroduce ${{ matrix.PLATFORM }} or an equivalent to ensure correct cross-platform builds.

          docker build -f .prebuild/${{ matrix.DOCKERFILE }} --build-arg BASE_IMAGE=${{ matrix.BASE_IMAGE }} --build-arg QEMU_ARCH=${{ matrix.QEMU_ARCH }} -t multiarch-build .

.github/workflows/Alternate Approach.yml:136

There's an unexpected tab/whitespace in runner.arch == 'X64' that may break YAML parsing. Replace with a single space before ==.

        if: ${{ (runner.os == 'macOS') && (runner.arch	 == 'X64') }}

.github/workflows/Stage 2 - Validate.yml:44

[nitpick] Including ubuntu-latest alongside explicit Ubuntu versions (ubuntu-24.04, ubuntu-22.04) duplicates runs since ubuntu-latest currently maps to ubuntu-22.04; consider removing redundancy.

        os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]

.github/workflows/Stage 2 - Validate.yml:44

windows-11-arm is not a standard GitHub Actions runner label; please verify runner availability or update to a supported label for ARM builds on Windows.

        os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…prebuilt-multiarch into beta-0.14.1

…80) * Initial plan * Add Node 25 (ABI 141) prebuild support and bump engines upper bound to <26.0.0 Agent-Logs-Url: https://github.com/homebridge/node-pty-prebuilt-multiarch/sessions/fca0e9db-8c83-4936-8a4a-5c14bb698e60 Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com> * Tweaks to scripts --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

package.json:25

The published package no longer includes src/ and deps/ (removed from the files allowlist), but the install script still falls back to node scripts/install.js, which runs node-gyp rebuild and requires those sources. This will make installs fail on any platform/Node ABI where a prebuild isn't available. Either include src/ and deps/ in the published package again, or remove/replace the node-gyp fallback with a clear error (and document the lack of source-build support).

  "files": [
    "binding.gyp",
    "lib/",
    "scripts/",
    "typings/",
    "prebuilds/linux-x64",
    "prebuilds/linux-ia32",
    "prebuilds/linux-arm",
    "prebuilds/linux-arm64",
    "third_party/conpty"
  ],

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T01:20:10Z

+        node-version: [18.x, 20.x, 22.x, 23.x, 24.x, 25.x]
+        os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-24.04-arm, macos-latest, macos-15, macos-14, macos-15-intel, windows-latest, windows-2025, windows-2022, windows-11-arm]
+        exclude:
+          - node-version: 18.x
+            os: windows-11-arm


This workflow still tests Node 18.x, but the package now declares engines.node as >=20.0.0 and the Stage 1 build matrix no longer builds Node 18 prebuilds. Keeping 18.x in the validation matrix is likely to produce false failures (or validate an unsupported runtime). Update the matrix to match the supported Node range (or adjust engines if Node 18 is still supported).

Suggested change

node-version: [18.x, 20.x, 22.x, 23.x, 24.x, 25.x]

os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-24.04-arm, macos-latest, macos-15, macos-14, macos-15-intel, windows-latest, windows-2025, windows-2022, windows-11-arm]

exclude:

- node-version: 18.x

os: windows-11-arm

node-version: [20.x, 22.x, 23.x, 24.x, 25.x]

os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, ubuntu-24.04-arm, macos-latest, macos-15, macos-14, macos-15-intel, windows-latest, windows-2025, windows-2022, windows-11-arm]

Copilot · 2026-04-30T01:20:11Z

+      - name: Windows ${{matrix.arch}} - Prebuild Binaries
        if: ${{ (runner.os == 'Windows') && (matrix.arch == 'x64') }}
        shell: bash
        run: |
          env JOBS=max node_modules/.bin/prebuild ${currentNodeBuildTargets} ${oldNodeBuildTargets} --include-regex "\.(node|exe|dll|pdb)" --arch ${{ matrix.arch }}
          env JOBS=max node_modules/.bin/prebuild ${electronBuildTargets} ${oldElectronBuildTargets} --include-regex "\.(node|exe|dll|pdb)" -r electron --arch ${{ matrix.arch }}


PR description says Electron support has been removed, but this workflow still builds Electron prebuilds for Windows x64 (-r electron ...). If Electron is truly being dropped, remove the Electron build targets/steps (and any related counts/artifacts). If Electron remains supported, the PR description should be updated to avoid a breaking-change mismatch.

Copilot · 2026-04-30T01:20:11Z

+      time: "09:00"
+    # Create PRs for out-of-date actions
+    open-pull-requests-limit: 10
+    target-branch: "latest"


target-branch is set to latest, but workflows in this PR were updated to use main as the primary branch. If the repository default branch has moved to main, Dependabot PRs targeting latest will be opened against a non-primary branch (or fail if it doesn't exist). Consider changing target-branch to main (or confirm that latest is still the intended maintenance branch).

Suggested change

target-branch: "latest"

target-branch: "main"

Copilot · 2026-04-30T01:20:11Z

 *.test.ts
+
+deps/
+src/


Ignoring deps/ and src/ here prevents them from being shipped in the tarball, which breaks the node-gyp rebuild fallback in scripts/install.js when prebuilds are missing. If source builds are still intended to work, these directories should not be excluded from the published package.

Suggested change

*.test.ts

deps/

src/

*.test.ts

NorthernMan54 added 29 commits July 3, 2025 09:25

Windows ARM

3e44aa6

Version TAG

c8e9fe7

Move versions lower then 20 into old, and add warnings for NodeJS low…

a0600f5

…er than 20

Add swap

6ffdca0

Update Dockerfile.alpine

4d2e41c

Create Alternate Approach.yml

b17df25

Merge branch 'main' into beta-0.14.0

f710005

Update Alternate Approach.yml

3f6eb56

Update Alternate Approach.yml

d1989ed

Update Alternate Approach.yml

1156189

Update Alternate Approach.yml

98549a2

Update Alternate Approach.yml

c98c3c5

Update Alternate Approach.yml

f69f870

Update Alternate Approach.yml

da7c364

Update Alternate Approach.yml

f7d56e7

Update Alternate Approach.yml

ff0e7b5

no qemu on arm

74e85a7

Update Alternate Approach.yml

a2246b7

Update Alternate Approach.yml

3224528

Update Alternate Approach.yml

c416013

Update Alternate Approach.yml

668302e

Update Alternate Approach.yml

c195b9f

fix

b03de93

simplify

dacfee5

Update Alternate Approach.yml

230c5c3

Update Alternate Approach.yml

2083683

publish

64d5357

Update package.json

6c16158

Oops on 0.14.0

6268d20

NorthernMan54 requested a review from Copilot July 6, 2025 04:50

NorthernMan54 linked an issue Jul 6, 2025 that may be closed by this pull request

Windows arm64 Support #45

Closed

Copilot AI reviewed Jul 6, 2025

View reviewed changes

Comment thread .prebuild/Dockerfile.alpine Outdated

NorthernMan54 marked this pull request as draft July 6, 2025 04:51

NorthernMan54 and others added 5 commits July 6, 2025 00:52

Update .prebuild/Dockerfile.alpine

45c47d1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Stage 2 - Validate.yml

58f0657

Merge branch 'beta-0.14.1' of https://github.com/homebridge/node-pty-…

4aa4400

…prebuilt-multiarch into beta-0.14.1

Fix version tags

100f5fd

Update Stage 2 - Validate.yml

3d14be3

NorthernMan54 mentioned this pull request Jul 6, 2025

Windows arm64 Support #45

Closed

Copilot AI and others added 6 commits April 27, 2026 12:34

Update Prepare prebuild environment.yml

3f7b8ba

Remove Node 18

9fedba0

More updates

6d834ae

Try

cf8fbed

Added OIDC Publishing

1f09fe1

NorthernMan54 requested a review from Copilot April 30, 2026 01:16

Copilot started reviewing on behalf of NorthernMan54 April 30, 2026 01:17 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

NorthernMan54 changed the title ~~Simplified and faster build process with Windows Arm Support~~ Spring 2026 Update Apr 30, 2026

Remove NodeJS 18

e0834b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Spring 2026 Update#62

Spring 2026 Update#62
NorthernMan54 wants to merge 41 commits into
mainfrom
beta-0.14.1

NorthernMan54 commented Jul 6, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

NorthernMan54 commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Breaking Change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NorthernMan54 commented Jul 6, 2025 •

edited

Loading