Prevent unregistering actionReceiver twice and handle weird lifecycle

[TimoPtr]

Summary

We have 1k users impacted by a crash of the AssistVoiceInteractionService while onShutdown is invoked, this PR catch the exception. It seems to happen because the system already unregistered the actionReceiver.

This PR also handle some weirdness of the lifecycle of the service here the documentation of onReady

    /**
     * Called during service initialization to tell you when the system is ready
     * to receive interaction from it. You should generally do initialization here
     * rather than in {@link #onCreate}. Methods such as {@link #showSession} will
     * not be operational until this point.
     *
     * <p>Note: Under some circumstances, it is possible for {@link #onReady} to be called after
     * {@link #onDestroy} has been called. This can happen in cases where the system is in the
     * process of shutting down the service, but the {@code IVoiceInteractionManagerService}
     * still sends a final "ready" signal. Therefore, implementations must be prepared for
     * {@link #onReady} to be called even after {@link #onDestroy}, and should not rely on a
     * fixed lifecycle order.
     */

and onShutdown

    /**
     * Called during service de-initialization to tell you when the system is shutting the
     * service down.
     * At this point this service may no longer be the active {@link VoiceInteractionService}.
     *
     * <p>Note: After this method is called, it is possible for other methods on this service
     * to be called, including {@link #onReady}. Implementations should be prepared to handle
     * this case gracefully.
     */

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

[Copilot]

Pull request overview

This PR hardens AssistVoiceInteractionService against unusual platform lifecycle ordering, especially late onReady() calls and receiver unregister crashes during shutdown.

Changes:

• Adds a teardown latch to ignore onReady() after shutdown or destroy.
• Defensively handles already-unregistered action receivers in onShutdown().
• Adds Robolectric tests for late lifecycle callbacks and duplicate unregister behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
app/src/main/kotlin/io/homeassistant/companion/android/assist/service/AssistVoiceInteractionService.kt	Adds lifecycle teardown guarding and defensive receiver unregister handling.
app/src/test/kotlin/io/homeassistant/companion/android/assist/service/AssistVoiceInteractionServiceTest.kt	Adds tests covering late onReady() and already-unregistered receiver scenarios.

[jpelgrom]

Interesting that we have so many users with the issue but didn't encounter it during testing 🤔