Add Android Assist VAD timing settings#6894
Closed
lextiz wants to merge 4 commits into
Closed
Conversation
Author
|
done |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable Voice Activity Detection (VAD) settings for Assist voice input, persists them in preferences, surfaces them in the Assist settings UI, and forwards them to the Assist websocket pipeline request.
Changes:
- Add Assist VAD preference storage (get/set) and plumb settings through config manager and view models.
- Extend
runAssistPipelineForVoicewebsocket API/payload to includevad_silence_secondsandvad_timeout_seconds. - Add settings UI fields (Compose) + strings and expand unit/screenshot tests.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/WebSocketRepository.kt | Extends voice pipeline API to accept optional VAD parameters. |
| common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketRepositoryImpl.kt | Adds VAD fields to websocket input payload when provided. |
| common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepository.kt | Introduces AssistVadSettings and new prefs APIs for VAD. |
| common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt | Implements VAD settings persistence + parsing helpers. |
| common/src/main/kotlin/io/homeassistant/companion/android/common/assist/AssistViewModelBase.kt | Passes VAD settings into voice pipeline websocket call via provider. |
| app/src/main/kotlin/io/homeassistant/companion/android/settings/assist/AssistConfigManager.kt | Exposes VAD settings get/set via config manager. |
| app/src/main/kotlin/io/homeassistant/companion/android/settings/assist/AssistSettingsViewModel.kt | Loads VAD settings into UI state and saves updates on change. |
| app/src/main/kotlin/io/homeassistant/companion/android/settings/assist/AssistSettingsScreen.kt | Adds VAD input section with two numeric text fields. |
| common/src/main/res/values/strings.xml | Adds user-facing strings for the VAD settings section. |
| common/src/test/.../WebSocketRepositoryImplTest.kt | Adds assertions covering inclusion/omission of VAD in websocket input. |
| common/src/test/.../PrefsRepositoryImplTest.kt | Adds tests for reading/writing VAD preferences. |
| common/src/test/.../AssistViewModelBaseTest.kt | Verifies VAD settings forwarded to websocket pipeline call. |
| app/src/test/.../AssistSettingsViewModelTest.kt | Adds tests for loading and saving VAD values via the settings VM. |
| app/src/test/.../AssistConfigManagerTest.kt | Adds tests for config manager VAD pass-through to prefs. |
| app/src/test/.../AssistViewModelTest.kt | Updates mocks and wiring to include VAD settings provider. |
| app/src/screenshotTest/.../AssistSettingsScreenScreenshotTest.kt | Updates screenshot test calls with new callbacks. |
| app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt | Wires vadSettingsProvider from AssistConfigManager. |
Author
|
Superseded by #6895 after CLA signing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional Assist silence and timeout overrides for voice runs. Related: home-assistant/core#122177.
Checklist