Add cached todo widget state test#6889
Open
sgallese wants to merge 1 commit into
Open
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds test coverage for mapping a TodoWidgetEntity containing cached latestUpdateData into the runtime TodoStateWithData model.
Changes:
- Added a unit test verifying
TodoStateWithData.from(todoEntity)correctly maps cached list name/items and marks the state as out-of-sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a test-only change to pin existing cached todo widget state behavior before any follow-up cleanup.
It adds coverage for how
TodoStateWithData.from(todoEntity)mapslatestUpdateDatainto display state.Checklist
Screenshots
No UI changes.
Link to pull request in documentation repositories
User Documentation: not needed; no user-facing functionality change.
Developer Documentation: not needed; no developer-facing documentation change.
Any other notes
This intentionally adds test coverage only and does not change widget, server, auth, location, notification, or schema behavior.
Validation:
./gradlew :app:testFullDebugUnitTest --tests io.homeassistant.companion.android.widgets.todo.TodoWidgetStateTest./gradlew :app:ktlintCheck