fix(ui): improve responsive media navigation and layouts - #646
Merged
Conversation
📝 WalkthroughWalkthroughソースメディアのルート再マウントと名称表示、メディアグリッド・ビューアー・検索レイアウト、ナビゲーションと検索UIを更新し、レスポンシブE2E検証を追加した。 Changesソースメディア表示とレスポンシブUI
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/server/src/tests/e2e/app-nav.responsive.spec.ts`:
- Around line 29-55: Update parseRgb and the contrast calculation around
relativeLuminance to detect oklch(...) computed colors and convert their OKLCH
components to sRGB before calculating luminance. Preserve RGB parsing for
rgb(...) values, and ensure the converted channels are represented on the 0–255
scale expected by relativeLuminance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6419ec1f-0e49-4b24-adaa-e19df821a415
📒 Files selected for processing (21)
apps/server/src/routes/sources/$mediaSourceId/$mediaId/index.tsxapps/server/src/routes/sources/$mediaSourceId/components/source-media-page.tsxapps/server/src/routes/sources/$mediaSourceId/index.tsxapps/server/src/tests/e2e/app-nav.responsive.spec.tsapps/server/src/tests/e2e/loading-recovery.spec.tsapps/server/src/tests/e2e/media-detail-manager-config.responsive.spec.tsapps/server/src/tests/e2e/route-reload.spec.tsapps/server/src/tests/e2e/search-pro-dialog.responsive.spec.tsapps/server/src/tests/e2e/search.responsive.spec.tsapps/server/src/tests/e2e/sources-source-media.responsive.spec.tspackages/ui/src/async-state.tsxpackages/ui/src/layouts/app-nav.tsxpackages/ui/src/media-viewer.tsxpackages/ui/src/pro-search-builder.tsxpackages/ui/src/screens/media-detail-screen.tsxpackages/ui/src/screens/search-screen.tsxpackages/ui/src/screens/source-media-screen.tsxpackages/ui/src/skeleton.tsxpackages/ui/src/source-media-grid.tsxpackages/ui/src/source-media-page.tsxpackages/ui/src/styles/theme.css
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
検索・メディア一覧・詳細表示で発生していたレスポンシブ表示とSPA遷移の不整合を修正します。
変更内容
検証
Summary by CodeRabbit
新機能
改善
品質向上