fix: Sources・Search・Source Mediaをモバイル対応 (#585) - #607
Conversation
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughモバイル検索フィルターを独立ダイアログ化し、検索状態のドラフト編集・適用・クリアを追加しました。Sources、ソースメディア、メディアグリッドのレスポンシブ表示と一括操作を更新し、関連するE2E検証を拡張しています。 Changesモバイル検索フィルターと状態管理
メディア操作と一括選択連携
レスポンシブ画面と操作レイアウト
レスポンシブE2E検証
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant MobileFilterButton
participant SourceMediaScreen
participant MobileSearchFilterDialog
participant searchState
MobileFilterButton->>SourceMediaScreen: フィルターを開く
SourceMediaScreen->>MobileSearchFilterDialog: open=true
MobileSearchFilterDialog->>searchState: draftを適用
MobileSearchFilterDialog-->>SourceMediaScreen: ダイアログを閉じる
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/server/src/tests/e2e/search-realtime-preservation.responsive.spec.ts`:
- Around line 96-108: Replace the DOM-based initialMediaCount in the responsive
search test with the authoritative total-result count, ensuring the initial
search has completed before reading it. Update the polling logic that compares
against initialMediaCount so it uses total results rather than rendered
[data-media-id] cards, preserving correct behavior with virtualization.
In `@apps/server/src/tests/e2e/sources-source-media.responsive.spec.ts`:
- Around line 18-22: Update expectTouchTarget to validate both dimensions of the
bounding box: preserve the existing minimum height assertion and add an
equivalent assertion requiring the width to be at least 44px.
In `@packages/ui/src/mobile-search-filter-dialog.tsx`:
- Around line 142-157: Update the draft initialization and handleApply flow to
incorporate the controlled selectedSource prop instead of relying only on the
internal searchState. When applying, propagate the draft’s selected source
through onSelectSource and keep the external source and draft synchronized
before invoking onSearch and closing the dialog.
- Around line 86-98: Update the label-building logic around the mode branch so
labels are added only when a search condition is configured: in pro mode, append
the detailed-condition label only when state.advancedCondition is set, and
otherwise append nothing; in the non-pro path, append the similar-source label
only when state.similarityAnchorMediaId is set. Preserve the existing
configured-label text and return behavior.
In `@packages/ui/src/search-control-panel.tsx`:
- Around line 186-195: Update the ProSearchDialog integration in the search
control panel so its internal search action does not bypass the outer Apply flow
or invoke handleApply. Make ProSearchDialog’s onSearch optional; when omitted,
treat its Search action as completion that only closes the internal dialog,
while preserving the existing onSearch behavior when provided.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4f53533f-d6cc-493c-824e-c276275ce5b1
📒 Files selected for processing (16)
apps/server/src/routes/search.tsxapps/server/src/routes/sources/$mediaSourceId/components/source-media-page.tsxapps/server/src/tests/e2e/search-realtime-preservation.responsive.spec.tsapps/server/src/tests/e2e/search.responsive.spec.tsapps/server/src/tests/e2e/sources-source-media.responsive.spec.tsapps/tauri/src/routes/search.tsxpackages/ui/src/media-list-actions.tsxpackages/ui/src/mobile-search-filter-dialog.tsxpackages/ui/src/preset-manager.tsxpackages/ui/src/screens/search-screen.tsxpackages/ui/src/screens/source-media-screen.tsxpackages/ui/src/screens/sources-screen.tsxpackages/ui/src/search-control-panel.tsxpackages/ui/src/source-card.tsxpackages/ui/src/source-media-grid.tsxpackages/ui/src/source-media-page.tsx
1 participant
概要
Sources、Search、Source Media を 320px 幅から操作可能なレスポンシブレイアウトへ調整します。
変更内容
検証
bun --filter @solid-imager/ui typecheckbun --filter @solid-imager/ui testbun --filter @solid-imager/server lintgit diff --check備考
apps/server単独 typecheck は、生成済み#route-treeがない既知の環境要因で失敗します。production E2Eのビルド・実行は成功しています。Fixes #585
Summary by CodeRabbit
新機能
改善