Conversation
Contributor
Author
|
wtf Codex stole my authorship |
LPTK
reviewed
Sep 21, 2026
Contributor
|
Thanks! As discussed,
|
LPTK
reviewed
Sep 21, 2026
| val fStrat = processResult(f) | ||
| val argsStrat = args.map(a => processResult(a.value)) | ||
| if args.exists(_.spread.isDefined) then | ||
| // TODO: preserve callee-effect precision for spread calls without modeling their argument flow. |
LPTK
reviewed
Sep 21, 2026
LPTK
reviewed
Sep 21, 2026
LPTK
marked this pull request as draft
September 21, 2026 10:37
flandia
force-pushed
the
flow-effect
branch
from
September 29, 2026 16:20
90c4747 to
f8cdcaa
Compare
Use MayHaveEffects for the analysis marker and summary, and mayHaveEffects for the metadata field, getters, and local flag. Update the corresponding golden outputs. Co-authored-by: Flandia <me@flandia.dev>
Run eta expansion only when definition lifting is enabled. Enable lifting in the eta regression suites and cover both settings with a minimal pure producer. Co-authored-by: Flandia <me@flandia.dev>
Remove the remaining annotation representation, conflict checks, lowering case, and flow-analysis override after source-level support was removed. Preserve the trusted @pure override. Co-authored-by: Flandia <me@flandia.dev>
Remove the standalone effect-analysis pass and configuration. Infer effects in the shared flow solver and include summaries in its debug output by default, with logEffects controlling reporting only. Support curried stages and conservatively handle multi-list calls so inference can run unconditionally. Drop the constructor-effect switch, configure effect tests through #config, and stabilize summary ordering. Include the corresponding golden outputs. Co-authored-by: Flandia <me@flandia.dev>
Carry annotations with rewritten function parameters and bodies so every definition builder consumes the eta rewrite's metadata. Remove stale @pure annotations when adding stages and mark extended calls as potentially effectful. Preserve existing deforestation annotations. Co-authored-by: Flandia <me@flandia.dev>
Increment affine annotation indices when lifting adds a capture parameter list, so the annotation continues to describe the original stage. Update the eta-expansion golden output for a captured affine lambda. Co-authored-by: Flandia <me@flandia.dev>
Adapt effect annotation checks and eta-expansion rewrites to upstream's explicit source locations. Preserve affine stage indices, effect flag names, and purity metadata cleanup. Co-authored-by: Flandia <me@flandia.dev>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This artifact is endorsed by Anto