Repository navigation
Fix invitation links and add a movable QR popup for BBB 3.0 and 4.0 - #1
Open
hiroshisuga wants to merge 30 commits into
Open
hiroshisuga wants to merge 30 commits into
hiroshisuga wants to merge 30 commits into
Conversation
Add comment for manual-copy fallback in modal.tsx
hiroshisuga
changed the title
Added fullscreen functionality to the modal, including state management and event listeners for fullscreen changes.
Add animation frame handling for popup window resizing.
SDK 0.1系の公開型にはApps Galleryなどはありますが、旧Action Menu APIはありません。SDK v0.1.xのPluginApi型 旧SDKでは正式に定義されていました。SDK v0.0.xのPluginApi型 また、旧SDKの ActionButtonDropdownOption は、複雑な処理をするものではなく、id、type、label、icon、onClick などを持つデータ記述用のクラスです。旧Optionクラスの実装 したがって、同じ構造のオブジェクトを直接作ることで、BBB 3.0側の処理へ渡せます。 つまり、以前の「SDK 0.1.26はAction Menu非対応」は、より厳密には次の意味です。 SDK 0.1.26の公開API・export・TypeScript型としてはAction Menuをサポートしていない。しかしBBB 3.0の実行環境には旧APIが存在するため、型を補って呼び出すことは可能。 これは正式なSDK互換機能ではなく、BBB 3.0の実装に依存する互換処理です。issue #232が解決すれば、この部分をより正式なAPIに置き換えられる可能性があります。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bigbluebutton#29, which is basically the same, except this PR puts the button in the Action Menu, instead of Action Bar, even though the SDK 0.1.26 drops the direct support to Action Button; this PR exploits the functions prepared by BBB3.0, irrespective of SDK implementation. The modification is: aa2b132