Fix managed self-update: refresh metadata and unlock Scoop's install dir#256
Merged
Conversation
Self-update ran the upgrade command against stale metadata, so new versions weren't found. Run an ordered two-step flow instead — refresh then upgrade (`brew update && brew upgrade …`, `scoop update; scoop update …`) — gated so a failed refresh aborts the upgrade, in both the GUI helper and console --update. Also fix the Windows helper failing with "…\current is in use": it inherited the app's own Scoop install dir as working directory. Launch it from TempPath. Update Updates unit tests for the new sequences.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-update ran the upgrade command against stale metadata, so new versions weren't found. Run an ordered two-step flow instead — refresh then upgrade (
brew update && brew upgrade …,scoop update; scoop update …) — gated so a failed refresh aborts the upgrade, in both the GUI helper and console --update.Also fix the Windows helper failing with "…\current is in use": it inherited the app's own Scoop install dir as working directory. Launch it from TempPath.
Update Updates unit tests for the new sequences.