Implement arbitrary string row ids#33
Merged
Merged
Conversation
Collaborator
Author
|
Factory verified: RFC 0005 implemented per accepted spec, 4-file scoped diff, own-MinIO test isolation honored, required check green. Merge-ready — this is the demo-family conversion unblock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id: Utf8and string-import mismatch against a fixed u64 namespaceCloses #31
Test Evidence
MinIO isolation: dedicated container
hevsearch-rowids-minioonHEVSEARCH_S3_ENDPOINT=http://127.0.0.1:19001; buckethevsearch-test.Passed:
cargo test -p hevsearch-core --test manager_local_fs string_ids -- --nocapturecargo test -p hevsearch-api --test api_string_ids -- --ignored --nocapturecargo test -p hevsearch-api --test api_import import_accepts_utf8_id_stream_and_rejects_existing_u64_namespace -- --ignored --nocapturecargo fmt --all --checkgit diff --checkcargo clippy --workspace --all-targets -- -D warningsBroad suite attempted:
cargo test --workspace -- --ignored --skip _aws --skip _100_runs_failed during linking, before tests ran:ld terminated with signal 9 [Killed]while linkingmanager_upsert_query, consistent with memory pressure from broad parallel test linking.cargo test --workspace -j1 -- --ignored --skip _aws --skip _100_runs_; it produced no output for several minutes after the linker retry and was interrupted.