Implement exact KNN query mode#32
Merged
Merged
Conversation
Collaborator
Author
|
Factory verified: RFC 0014 implemented per accepted spec — exact/hybrid routing through bypass_vector_index, exact+nprobes rejected, shared prefilter path covered, exact-vs-indexed recall evidence in body. Required check green in 3m57s (the #28 fix paying for itself). Merge-ready — merging also flips #30 (bench ground-truth tie-in) to ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact: trueto/queryand routes vector/hybrid vector legs through LanceDBVectorQuery::bypass_vector_index().exact+nprobes, FTS-onlyexact, and enabled semantic cache with exact mode.Closes #29.
Bench integration follows as #30.
Evidence
./scripts/cargo fmt --all -- --check✅./scripts/cargo clippy --workspace --tests --benches -- -D warnings✅HEVSEARCH_S3_ENDPOINT=http://127.0.0.1:19000 ./scripts/cargo test -p hevsearch-api --test api_exact_knn -- --ignored --nocapture✅Exact vs indexed seeded PQ namespace (
k=20, IVF_PQnum_partitions=16,num_sub_vectors=4,num_bits=4, indexednprobes=1):Full ignored workspace attempt:
HEVSEARCH_S3_ENDPOINT=http://127.0.0.1:19000 ./scripts/cargo test --workspace -- --ignored --skip _aws --skip _100_runs_ --nocapturedid not complete in this local container because linking was killed by the OS (collect2: fatal error: ld terminated with signal 9 [Killed]) while buildingobject_cache_s3_smoke/hevsearch-coretest binaries.-j 1; same linker OOM class, so targeted MinIO coverage above is the passing evidence for this change.