Use Boost::json in olp-cpp-sdk-dataservice-write#1680
Closed
rustam-gamidov-here wants to merge 2 commits into
Closed
Use Boost::json in olp-cpp-sdk-dataservice-write#1680rustam-gamidov-here wants to merge 2 commits into
rustam-gamidov-here wants to merge 2 commits into
Conversation
Migrating from RapidJSON Relates-To: OCMAM-445 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Prevents exposing internal headers from being exposed. Could be converted to OBJECTS or static lib if there's need with linking boost to it privately. Considered to be an improvement opportunity for future Relates-To: OCMAM-445 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1680 +/- ##
=====================================================
Coverage ? 80.49%
=====================================================
Files ? 354
Lines ? 14060
Branches ? 1523
=====================================================
Hits ? 11317
Misses ? 2125
Partials ? 618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
closing in favour of #1681 |
rustam-gamidov-here
deleted the
rga/ocmam-445-boost-to-write-common-includes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating from RapidJSON
Move json headers from core to internal location. Prevents exposing internal headers from being exposed.
Could be converted to OBJECTS or static lib if there's need with linking boost to it privately. Considered to be an improvement opportunity for future
Relates-To: OCMAM-445