Skip to content

Support Linux ARM binaries#26

Merged
hellwolf merged 2 commits into
hellwolf:masterfrom
blishko:master
Jan 19, 2026
Merged

Support Linux ARM binaries#26
hellwolf merged 2 commits into
hellwolf:masterfrom
blishko:master

Conversation

@blishko

@blishko blishko commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Since 0.8.31 solc support Linux ARM binaries.

Resolves #25.

@blishko

blishko commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@hellwolf, I am not sure I am doing this correctly, so please, feel free to update it!

@hellwolf

Copy link
Copy Markdown
Owner

Thank you! Do you think you could help add it to the CI matrix:

os: [ubuntu-latest, macos-14, macos-15, macos-15-intel]
? I am not sure if aarch64-linux available in github yet.

@hellwolf

Copy link
Copy Markdown
Owner

Now some linting error, please try with nixfmt

@blishko

blishko commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

Working on it. I also need to add SHA for versions 0.8.32 and 0.8.33.

I have two questions.
Should I add the commented-out messages about "solc-static-linux-arm not available for this version" for all the previous versions in solc-listing.nix?
Also, should it be called solc-static-linux-arm or would solc-static-linux-aarch64 be more suitable (and consistent with the mac naming)?

@blishko

blishko commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

solc-static-linux-arm is the name of the binary as released by solc.

@blishko

blishko commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

I had to update also the version with which nix shell is being tested on CI.
Also, should I update also test/flake.nix?
It seems aarch64-linux should be added there as well?

@hellwolf

Copy link
Copy Markdown
Owner

Thanks. CI still broken, upon examination, i think we also need to update the /flake.nix

    flake-utils.lib.eachSystem
      [
        "x86_64-linux"
        "x86_64-darwin"
        "aarch64-darwin"
      ]

Also, should I update also test/flake.nix?
It seems aarch64-linux should be added there as well?

I don't see why not!

@blishko

blishko commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

I had added the new architecture to flake.nix before, now I have added it to test/flake.nix as well. I think that's what has been missing.

Comment thread utils/download.sh Outdated
https://github.com/argotorg/solidity/releases/download/v"$v"/solc-static-linux \
"$T"/bin/static-linux/solc-"$v"

#if [ "$(semver compare $v 0.8.30)" == 1 ]; then

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, why is the if-code lines commented out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for spotting that!
I was running this script on my laptop with MacOS and semver does not exist there.
I'll uncomment it!

BTW, how have you been running this script? Where did you get semver from?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, how have you been running this script? Where did you get semver from?

I use NixOS, https://search.nixos.org/packages?channel=unstable&query=semver is available.

@hellwolf

Copy link
Copy Markdown
Owner

All CI passed, great stuff!

Just one more comment above, then we are good to go!

@hellwolf hellwolf merged commit 80ad871 into hellwolf:master Jan 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linux-arm builds

2 participants