[codex] Preserve inbound webchat teaser layout#46
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bae0e6a16e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps inbound webchat message teasers inside the server-rendered teaser layout instead of replacing the entire teaser shell.
Root Cause
The SDK previously handled inbound message teasers by assigning the teaser payload to
teaserTarget.innerHTML. That replaced the outer teaser contents and wiped out the styled.hellotext--webchat-teaser-stack/.hellotext--webchat-teaser-messagestructure rendered by Rails.What Changed
inboundMessageTeaserBodyTarget, and unhideinboundMessageTeaserTarget.teaserTargetresponsible only for visibility, so positioning and styling remain intact.libanddistoutputs.Verification
yarn test __tests__/controllers/webchat_controller_test.js --runInBandyarn test --runInBandyarn buildgit diff --checkNote
Low Risk
UI-only teaser rendering with graceful fallbacks when targets are missing; covered by focused controller tests.
Overview
Inbound webchat message teasers no longer replace the entire
teaserTargetDOM (which stripped Rails-rendered.hellotext--webchat-teaser-stackmarkup). The controller now uses dedicated Stimulus targets—teaserMessage,inboundMessageTeaser, andinboundMessageTeaserBody—to hide configured teaser stacks, inject the payload into the inbound slot, and toggle only outer teaser visibility.Tests in
webchat_controller_test.jswere expanded with DOM helpers and assertions that the teaser shell stays intact, inbound content lands in the right target, session “teaser seen” is not set for ephemeral inbound teasers, and message handling still works when inbound teaser targets or the teaser surface are missing (including carousel messages).Reviewed by Cursor Bugbot for commit a883d24. Bugbot is set up for automated code reviews on this repo. Configure here.