Repository navigation
fix: read catalogue-form author names given name first - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
What
graph.build.cleanrewrites author names in library-catalogue form,Last, First 1968-, asFirst Lastwith the life dates dropped. Names in a script written family name first (CJK) lose the comma but keep their order. Names with no comma or with several commas, such as an organization with its address, are left alone.renamed_authors.Why
The client joins author names with commas, so a catalogue-form name read as two people: "Olivier Chapelle, Schölkopf, Bernhard 1968-, Alexander Zien". On the current raw crawl the rule rewrites 267 name occurrences (252 distinct names). The cleaned graph has the same nodes, edges and per-work author counts as the served
gnn-20260929, and the model only reads the author count, so neither the dataset nor the model changes.The rule only fixes name order. Mojibake (
Siekmann, JörgbecomesJörg Siekmann) and ids OpenAlex appends (Y Yang (6099497)) are separate issues.Verify
uv run pytest tests/test_build.py uv run python -m graph.build --field gnn # logs renamed_authors; the snapshot needs gnn.dataset and gnn.train before the API can serve itGenerated with Claude Code