Repository navigation
fix: give training the patience to outlast its early popularity peak - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
What
TrainConfigdefaults go from 400 epochs and patience 40 to 600 epochs and patience 100.PLAN.md's expanded-snapshot results now come from the served snapshot, trained with these defaults.Why
On the expanded snapshot, one step from a random start ranks by popularity alone, and validation AP reads 0.899. Learning more dips below that before rising past it: 0.86 at epoch 2, 0.90 at 50, 0.92 at 150, 0.93 at 300. With patience 40, training kept epoch 1 and stopped at 41. The served model was effectively untrained.
With the new defaults,
gnn.evaluateon the served snapshot, paired over 15 runs against the logistic baseline:The plan had recorded that the model only tied popularity under year-matched negatives. That came from the undertrained model. On the old snapshot, training already settled around epoch 100 and is unaffected.
Verify
Generated with Claude Code