Conversation
johallar
marked this pull request as draft
September 28, 2026 22:16
johallar
marked this pull request as ready for review
September 29, 2026 15:44
cmatzenbach
approved these changes
Sep 30, 2026
Collaborator
|
LGTM — nice catch on the importDashboard tabs bug (worth mentioning in the description). Couple of non-blockers: (1) git config --global --add on the self-hosted runner may leak/accumulate across jobs and collide with release.yml's token rewrite unless runners are ephemeral — consider GIT_CONFIG_* env vars; (2) stale comment referencing the Puppeteer workflow; (3) Login lost PureComponent memoization — React.memo?; (4) the UI test assertions got quite a bit looser — fine if intentional for the new dataset, but maybe defer to the Puppeteer follow-up. |
patdevinwilson
self-requested a review
October 2, 2026 17:55
patdevinwilson
approved these changes
Oct 2, 2026
patdevinwilson
left a comment
patdevinwilson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — see previous comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Description
Put this off too long, migrate CI to gh actions