Skip to content

feat(web): add global search UI - #29

Closed
KareemN1936 wants to merge 1 commit into
trello-next-3from
feat/global-search-ui
Closed

KareemN1936 wants to merge 1 commit into
trello-next-3from
feat/global-search-ui

Conversation

@KareemN1936

Copy link
Copy Markdown
Collaborator

Summary

  • Replace disabled header/mobile search placeholders with a reusable global search form.
  • Add a /search web route that queries the /search API from PR feat(api): add canon consistency and search #28 and links world/lore results into existing pages.
  • Add a typed web search API client for the global search endpoint.

Trello

  • Selected the visible global search UI follow-up after reviewing PR feat(api): add canon consistency and search #28 context. The Trello connector exposed in this session could not list the board/cards or resolve short Trello card URLs, so I could not reliably attach the exact card URL in this PR body.

Stack

Verification

  • npm run typecheck --workspace=@hivelore/web
  • npm run lint --workspace=@hivelore/web
  • npm run test --workspace=@hivelore/web
  • npm run build --workspace=@hivelore/web
  • npx prettier --check apps/web/src/lib/api/search.ts apps/web/src/components/layout/global-search-form.tsx apps/web/src/components/layout/site-header.tsx apps/web/src/components/layout/mobile-navigation.tsx apps/web/src/app/search/search-results-client.tsx apps/web/src/app/search/page.tsx
  • git diff --check -- apps/web/src/lib/api/search.ts apps/web/src/components/layout/global-search-form.tsx apps/web/src/components/layout/site-header.tsx apps/web/src/components/layout/mobile-navigation.tsx apps/web/src/app/search/search-results-client.tsx apps/web/src/app/search/page.tsx

@KareemN1936

Copy link
Copy Markdown
Collaborator Author

Implementation note for the global search UI follow-up:

This PR turns the existing disabled header/mobile search placeholders into a working search flow stacked on PR #28's /search API.

Implemented:

  • reusable GlobalSearchForm used by desktop header and mobile navigation;
  • typed web client for the search endpoint;
  • /search page that fetches results, renders world/lore badges, and links into existing world/lore routes.

Verification run locally:

  • npm run typecheck --workspace=@hivelore/web
  • npm run lint --workspace=@hivelore/web
  • npm run test --workspace=@hivelore/web (2 files, 6 tests passed)
  • npm run build --workspace=@hivelore/web
  • focused prettier --check
  • focused git diff --check

Note: Trello MCP in this session could not list the HiveLore board/cards or resolve existing short Trello URLs, so I could not move/comment the exact Trello card from here.

@KareemN1936
KareemN1936 requested a review from mcfarhat September 5, 2026 22:58
@KareemN1936

Copy link
Copy Markdown
Collaborator Author

Closing this because it was opened from inferred repo context instead of a confirmed Trello To Do card. We’ll redo the workflow from the Trello board/cards first.

@KareemN1936 KareemN1936 closed this Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Vercel preview is ready:

https://hivelore-p54e9blb3-kareemn1936s-projects.vercel.app

Commit: 4bad5c4

@KareemN1936
KareemN1936 deleted the feat/global-search-ui branch September 5, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant