Repository navigation
docs: approval percentage counts all votes cast, not Approve + Reject - #23
Merged
Merged
Conversation
The MVP canon rule counted different populations in its two halves: the quorum counted all four vote choices, while the approval percentage counted only Approve + Reject. Measured against the implementation, that let 1 Approve + 4 Needs Revision satisfy both conditions and canonize permanently on-chain, and 5 Approve + 20 Needs Revision did the same. It also meant a voter choosing Needs Revision had less effect on the outcome than one voting Reject, penalising the more constructive option. Decision by Mohammad, 2026-08-11: count every vote cast in the denominator so both halves of the rule count the same population. Already implemented in PR #22. Co-Authored-By: Claude <noreply@anthropic.com>
|
Vercel preview is ready: https://hivelore-c2cg8moza-kareemn1936s-projects.vercel.app Commit: e6a6aee |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects §4.2 of
docs/planning/product-world-ux.mdto match the ruling made today and already implemented in #22.Why
The MVP canon rule counted different populations in its two halves:
Measured against the implementation before the fix:
So one supporter and four people asking for revision canonized a contribution permanently on Hive mainnet, and five supporters beat twenty dissenters. It also meant a voter choosing Needs Revision had less effect on the outcome than one voting Reject — penalising the more constructive option.
What changed
Approval now counts Approve against all votes cast. Both halves of the rule count the same population. With the new denominator:
The trade-off Mohammad accepted: Needs Revision now behaves arithmetically like a soft Reject, with the distinction carried by the feedback rather than the maths.
Note
Docs-only, one line changed plus an inline note recording why, so the next person doesn't reimplement the original rule from the source of truth. The code change is already in #22 (
canon-voting-policy.ts), verified across all seven boundary cases, with a regression test named "constructive dissent prevents approval instead of disappearing from the denominator".🤖 Generated with Claude Code