Skip to content

Feature/worlds frontend - #17

Closed
KareemN1936 wants to merge 2 commits into
developfrom
feature/worlds-frontend
Closed

KareemN1936 wants to merge 2 commits into
developfrom
feature/worlds-frontend

Conversation

@KareemN1936

Copy link
Copy Markdown
Collaborator

No description provided.

@mcfarhat

mcfarhat commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@KareemN1936 see my note on #16 — short version: this PR and #16 change the same three worlds pages in incompatible ways.

The UI work here is good, but it's built on lib/worlds/mock-worlds.ts (285 lines of hardcoded fixtures) rather than the API, and worlds/new has no submit path — so merging it would ship a worlds section that looks finished but does nothing, and it would overwrite the live API integration in #16.

Please fold this PR's styling and responsive layout onto #16's API wiring and close whichever one ends up redundant. #16 should be the base since it's built on Perla's backend branch.

Also, independent of which survives: this PR deletes the pre-paint theme script in layout.tsx and moves theme-provider to useEffect, which reintroduces a white flash for dark-mode users on every load and drops cross-tab/OS theme sync — details on #16.

Security-wise this is clean — no XSS, no secrets, no draft leakage — it's purely the mock-data and duplication issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants