Repository navigation
M4: add persistent lobby lifecycle and host migration - #6
Merged
Merged
Conversation
mhmdibrahimm
marked this pull request as ready for review
July 23, 2026 22:43
mcfarhat
approved these changes
Jul 24, 2026
mcfarhat
left a comment
Contributor
There was a problem hiding this comment.
@mohammadibrahim3 Approved & merging — excellent first M4 deliverable. ✅ Server-authoritative lobby, host always re-derived from the open host-assignment row with per-command ownership + version rechecks, transactional disconnect-driven host migration, WAX-only, least-privilege, no secrets. Node build/typecheck/tests + all 5 CI jobs green (incl. Go -race, Postgres, and the two-player migration smoke test). Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Trello card #30 · M4 Persistent lobby lifecycle + host migration.
The start request records an accepted lobby transition; round creation and gameplay state remain scoped to card #31.
Validation
npm run verifyBuild Finished, Result: Success)Test notes
The credential-bearing two-client visual check is documented in
clients/unity/README.md. Development WebGL builds containing a temporary access token must remain local and must not be deployed.