Skip to content

Compose role rework#67

Merged
hazzuk merged 12 commits into
devfrom
compose-role
May 23, 2026
Merged

Compose role rework#67
hazzuk merged 12 commits into
devfrom
compose-role

Conversation

@hazzuk
Copy link
Copy Markdown
Owner

@hazzuk hazzuk commented May 20, 2026 •
edited
Loading

Description

This is a large PR, which primarily changes how secrets are handled when creating stacks. It also reworks large parts of the compose role itself. Bringing cleaner code and improved reliability.

Additionally, some of the changes made to the compose role inspired smaller related improvements elsewhere in the playbook.

Changes

  • Inject secrets dynamically using files instead of hardcoded environment variables.
  • Add asserts for the compose role. Ensuring the user has setup Docker, and is using a valid stack name.
  • Improve logging output when running the playbook. Especially with loops in the compose role.
  • Simplify and deduplicate code.

And

  • Standardise tmpfs directory paths (inline with the new path secrets files are created at).
  • Avoid the need to input the system's become password when running the playbook.

Notes

Checklist

  • Written documentation
  • Linked relevant issues

hazzuk added 12 commits May 18, 2026 22:25
@hazzuk
feat(compose): inject secrets securely using files
806cc7e 
The existing environment variables logic was cumbersome. And environment variables can be logged in plaintext.
@hazzuk
feat(ansible): unify loop logging with labels
57360e9
@hazzuk
refactor(ansible): remove with_items from playbook
1d9dde7
@hazzuk
feat(justfile): reduce redundant compose role logging
f0db31e 
When modifying a specific stack, Ansible would mark every other stack as skipped.
@hazzuk
chore(ansible): unify tmpfs directory path usage
b443593
@hazzuk
feat(ansible): disable become_ask_pass by default
90cf9f4 
Ansible will now expect the user to set their sudo password inside their vault using `ansible_become_password`.
@hazzuk
refactor(compose): restructure secrets variables
691e0a3
@hazzuk
refactor(compose): consolidate become/tags parameters
b533725
@hazzuk
refactor(compose): simplify stack name check
145521c
@hazzuk
feat(compose): assert docker setup and stack name
8b98818 
Ensures the user has setup Docker, and is using a valid stack name.
@hazzuk
refactor(compose): defer secrets dir creation
ae5955b 
Directory will now only be created if required.
@hazzuk
chore(compose): disable marking secrets tasks as changed
ecbf130
@hazzuk hazzuk requested a review from mosslocker May 20, 2026 22:12
@hazzuk hazzuk added Kind/Enhancement Improve existing functionality Kind/Feature New functionality Status/Needs Documentation Documentation changes required labels May 20, 2026
@hazzuk
Copy link
Copy Markdown
Owner Author

hazzuk commented May 23, 2026

Docs updated with PR changes:

@hazzuk hazzuk removed the Status/Needs Documentation Documentation changes required label May 23, 2026
@hazzuk hazzuk merged commit c71b283 into dev May 23, 2026
@hazzuk hazzuk deleted the compose-role branch May 23, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosslocker mosslocker mosslocker approved these changes

Assignees

No one assigned

Labels

Kind/Enhancement Improve existing functionality Kind/Feature New functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hazzuk @mosslocker