feat: add USB transport support#16
Draft
okhsunrog wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--usbas an alternative to BLE discovery for one-shot commands and the interactive console.IqosTransport.Dependency / draft status
This draft depends on hauntedfail/iqos#5.
The manifest intentionally uses the feature branch for review and reproducible CI:
Before this PR is marked ready or merged:
iqoscrate release.Cargo.lockand rerun the verification commands.User impact
Users can connect directly to an attached IQOS without BLE scanning:
Read-only brightness, vibration, FlexPuff, FlexBattery, and AutoStart queries use the same command implementations as BLE. Stateful USB commands remain experimental.
Hardware validation
Validated on an IQOS ILUMA i over BLE and USB. Product numbers, firmware versions, settings, battery voltage, and diagnosis counters matched across transports. Diagnosis returned identical raw counters (
1296usage counter and1074currently unidentified counter); their exact semantics remain unverified. Battery voltage matched at4.614 V.Verification
cargo fmt --all --checkcargo check --lockedcargo test --all-targets --locked(66 tests)cargo clippy --all-targets --locked -- -D warningsRelease notes
--usb.feature