feat: rate limit CRUD ops from the CLI/TUI#4474
Open
mnafees wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mnafees
commented
Jul 21, 2026
| return client.NewFromConfigFile( //nolint:staticcheck | ||
| configFile, | ||
| client.WithLogger(logger), //nolint:staticcheck | ||
| client.WithTLSConfig(tlsConfig), //nolint:staticcheck |
Member
Author
There was a problem hiding this comment.
I specifically added this after a local env var that I need for local dev was overriding the TLS behavior for my CLI. I think this makes sense to me but happy to debate on the design.
mnafees
commented
Jul 21, 2026
Comment on lines
+583
to
+590
| case types.Day: | ||
| putParams.Duration = admincontracts.RateLimitDuration_DAY | ||
| case types.Week: | ||
| putParams.Duration = admincontracts.RateLimitDuration_WEEK | ||
| case types.Month: | ||
| putParams.Duration = admincontracts.RateLimitDuration_MONTH | ||
| case types.Year: | ||
| putParams.Duration = admincontracts.RateLimitDuration_YEAR |
Member
Author
There was a problem hiding this comment.
These were all missing and so it would always default to seconds, whoops 🤐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new set of subcommands to manage rate limits from the CLI with
hatchet rate-limits create,hatchet rate-limits update, `hatchetType of change
Checklist
Changes have been:
🤖 AI Disclosure