feat(dashboard): discoverable theme toggle + system default#4471
Open
avirajkhare00 wants to merge 3 commits into
Open
feat(dashboard): discoverable theme toggle + system default#4471avirajkhare00 wants to merge 3 commits into
avirajkhare00 wants to merge 3 commits into
Conversation
Add a visible theme toggle on auth pages and the top nav (Light/Dark/System), default to the OS preference, apply theme before paint, and remove the duplicate theme submenu from the account dropdown.
|
@avirajkhare00 is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThemeToggle(Light / Dark / System) on the login/register layout and in the top nav, so light mode is easy to find.prefers-color-scheme), with a pre-paint script to avoid FOUC and live updates when the OS theme changes.Test plan
VITE_API_PROXY_TARGET=http://127.0.0.1:8888 pnpm dev)localStorage(orvite-ui-theme=system), UI follows OS light/dark