feat: register a CLI profile for running embedded engines - #9
Merged
Merged
Conversation
When the engine becomes ready, StartServer registers an embedded profile in the CLI profile store (~/.hatchet/profiles.yaml, created if absent) with the minted token and endpoints, plus metadata fields the released CLI ignores (embedded, pid, cwd, startedat). Registration is always attempted and never fails startup: write and permission errors log a warning and continue. Graceful shutdown removes the entry only when its token still matches this instance, so a newer engine's registration survives. The user's default profile is never changed. The writer honors the CLI's config lock protocol and profile file name overrides, upserts via yaml.Node so other profiles, ordering, and comments are preserved, and writes atomically. Timestamps must be emitted as unquoted YAML timestamps because viper does not decode quoted strings into time.Time; the upsert forces block style and a regression test guards it. Registration is skipped under WithoutAPI since such a profile would be unusable and unverifiable. The sidecar inherits this through StartServer, so TypeScript and Python embedded runs register identically with no SDK changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHyfTNZGxYR249FURndHEX
Replaces the duplicated profile-writing machinery (path resolution, lock protocol, yaml.Node surgery, atomic writes, roughly 350 lines) with the profilestore package the CLI itself now uses, so all writers share one implementation. Registration upserts through UpsertProfile with the embedded metadata fields, always including cwd since upserts merge rather than replace, and deregistration uses RemoveProfileIfTokenMatches. Store construction happens inside register and deregister so failures stay best-effort warnings that never fail engine startup. Tests are pruned to this repo's semantics; format-fidelity coverage lives in the profilestore suite. Verified live against the released v0.106.11 CLI: registration parses and lists, comments survive, graceful shutdown removes the entry, re-registration into an emptied file stays readable, and a killed engine leaves a stale entry as designed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHyfTNZGxYR249FURndHEX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates an embedded profile in
~/.hatchet/profiles.yamlafter embedded mode starts up, which can be used by other tools relying on CLI profiles (such as an MCP server,hatchet tui, etc).Type of change
Checklist
Changes have been:
🤖 AI Disclosure