fix: Skill updates no longer show a completion dialog#1432
Merged
Conversation
Keep the first-install success dialog while making skill updates rely on the refreshed Installed state instead of showing a completion dialog.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTwo editor windows add internal helpers to decide when to show the skills-installed dialog. The SetupWizard path now checks all installable targets, and the UnityCliLoop path checks the selected target after resolving its install state. Tests cover Missing, Outdated, and different-layout cases. ChangesConditional skills-installed dialog
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Packages/src/Editor/Presentation/UnityCliLoopSettingsWindow.cs`:
- Around line 1027-1028: The dialog decision is still based on the cached
_selectedTargetInstallState, which may be stale because it is refreshed
asynchronously. Update UnityCliLoopSettingsWindow so the selected target’s
install state is recomputed with a fresh check immediately before calling
ShouldShowSkillsInstalledDialog, and use that fresh value instead of the cached
field when deriving shouldShowSkillsInstalledDialog. Keep the fix localized
around the existing ShouldShowSkillsInstalledDialog flow and the
_selectedTargetInstallState usage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fac7be07-20c3-4073-95d4-b223e26a4368
📒 Files selected for processing (4)
Assets/Tests/Editor/SetupWizardWindowTests.csAssets/Tests/Editor/UnityCliLoopSettingsWindowCliActionTests.csPackages/src/Editor/Presentation/Setup/SetupWizardWindow.csPackages/src/Editor/Presentation/UnityCliLoopSettingsWindow.cs
Treat existing skills in a different layout as an update path so Setup Wizard does not show the first-install success dialog after migrating them.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Packages/src/Editor/Presentation/UnityCliLoopSettingsWindow.cs">
<violation number="1" location="Packages/src/Editor/Presentation/UnityCliLoopSettingsWindow.cs:1028">
P2: Race condition: `_selectedTargetInstallState` is refreshed asynchronously and may be stale when the user clicks install. If the async refresh hasn't completed yet, an actually `Outdated` target could still hold `Missing` state, causing the success dialog to incorrectly appear during an update flow. Consider re-evaluating the install state synchronously here (e.g., via `GetSelectedTargetInstallState` with a freshness check) before deciding whether to show the dialog.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Read the selected skill target details before installing so Settings treats existing skills in a different layout as an update instead of a first install.
This was referenced Jun 29, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
Changes
Verification