feat: Launch Unity with compiler errors or a chosen Editor version#1423
Conversation
Allow uloop launch to pass Unity Editor's -ignorecompilererrors argument so projects can open even when compiler errors would otherwise block startup. - Add -i/--ignore-compiler-errors parsing and launch argument construction. - Document the flag in help, completion, and the launch skill.
Allow uloop launch to select an installed Unity Editor version without changing ProjectVersion.txt, and advance the dispatcher release metadata because launch is handled by the dispatcher. - Parse and document --editor-version for launch. - Use the override when resolving the Unity executable path. - Cover dispatcher-owned launch options before project pin resolution.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughTwo new ChangesNew launch flags and launch flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Prevent uloop launch from reporting an existing Unity process as ready when --editor-version requests a potentially different Editor version. Users must opt into --restart so the requested version can be applied to a new Editor process. - Fail fast when --editor-version is used against an already running project without --restart. - Add a regression test for the existing-process path.
Summary
uloop launchcan now start Unity even when compiler errors are present when callers opt in with-ior--ignore-compiler-errors.uloop launchcan now select a specific installed Unity Editor version with--editor-versionwithout changing the project version file.User Impact
Changes
-ignorecompilererrorsargument only when requested.--editor-versionbefore falling back to the project version.Verification
go test ./internal/cliscripts/check-go-cli.shgo run ./cmd/check-dispatcher-minimum-versiongo run ./cmd/check-dispatcher-version-bump --base origin/v3-beta --head HEAD/Users/a12115/dotfiles/.claude/skills/autoreview/scripts/autoreview --mode branch --base origin/v3-beta