fix(monitors): reauthorize before process spawn - #535
Merged
Conversation
Agent: iapp-factory-coordinator
Agent: iapp-factory-coordinator
Recheck the current thread writer, permission profile, and cwd after the start event is persisted, and use only the refreshed execution context for the sandboxed child. Agent: iapp-factory-coordinator
Agent: iapp-factory-coordinator
Contributor
Author
|
[REVIEW] GO — #535 @ 05c98cb — lens: correctness+security+gates, reviewer Damon (1 of 1) Reviewed exact candidate
What I ran
Forge checks read
Blocking P0/P1 findings
Non-blocking follow-up
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression
thread_monitor_runtime_does_not_spawn_after_permission_changes_during_start_event_persistencepauses after event persistence, mutates the live permission profile, resumes, and requires failure without a process id4aef7a22b95bf3a3925137b53175d74fadc96353: named stale-authorization assertion failedLocal gates
just fmtgit diff --checkand cached diff checkTodos: f4a9b60f-b202-4a0d-b7bc-bb6ac2f43099
Focused re-review remains assigned only to Lovelace session
019fe802-b5ae-7033-ba6d-e6f7185dd943after remote gates.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.