Conversation
Member
Author
|
not sure why the linter fails, as it complains about lines I didn't change? |
Contributor
|
"It is likely due to how the constructor is defined. The super hashlist component uses the 'traditional way,' but Angular now requires the inject() function. You can find an example of this in new-hashlist.component.ts on lines 41–49. That should fix your issue. Since the spec for super hashlist has changed, the component was retested, which is why the linter is now complaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were inconsistencies how titles and texts were written for some objects (where presented to the user), these adjusts it to what should be used (and was used already until now also in the previous frontend), typically not having camel case for single words:
Hashlist(notHashListSuperhashlist(notSuperHashlistorSuperHashList)Preconfigured Task(notPreTask)Supertask(notSuperTask)NOTE: I only changed any textual representation shown to the user and in comments, not in any variables or other programmatic elements!