fix(ui): unlock document scroll after list delete mutations - #32050
Open
sushant-kataria wants to merge 1 commit into
Open
fix(ui): unlock document scroll after list delete mutations#32050sushant-kataria wants to merge 1 commit into
sushant-kataria wants to merge 1 commit into
Conversation
Deleting an item in long KV/policies/auth lists could leave scrolling fully disabled until reload. Restore body/html overflow after destroy and expose a small unlock helper for list delete paths. Fixes hashicorp#31852
dosubot
Bot
added
size:XS
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After deleting a row in long Vault UI lists (KV, policies, auth methods), scrolling could remain fully disabled until a hard refresh. This restores
documentoverflow after list destroy mutations and adds a smallunlockDocumentScrollhelper for delete paths.Fixes #31852
Test plan
Notes
Happy to retarget the unlock call to the exact list component maintainers prefer if body-level overflow is not the lock source in 1.21.x.