Skip to content

fix: work around deleted plugin release - #11771

Merged
zchsh merged 2 commits into
mainfrom
zs.fix-huawei-plugin-source
May 10, 2022
Merged

fix: work around deleted plugin release#11771
zchsh merged 2 commits into
mainfrom
zs.fix-huawei-plugin-source

Conversation

@zchsh

@zchsh zchsh commented May 10, 2022

Copy link
Copy Markdown
Contributor

This PR pins the versions of huaweicloud/packer-plugin-huaweicloud and ivoronin/packer-plugin-sshkey. Without these plugin packages pinned, we run into build errors, which affect our deployments of hashicorp/dev-portal.

Note: we're working on a more robust fix for this issue in hashicorp/web-platform-packages#47. That fix will allow use to provide more robust resolution of docs .mdx files when versions is set to latest. This may mitigate the need to pin plugins to specific versions when they fail.

@zchsh
zchsh marked this pull request as ready for review May 10, 2022 17:36
@zchsh
zchsh requested a review from a team as a code owner May 10, 2022 17:36
@zchsh
zchsh requested a review from brkalow May 10, 2022 17:36
@nywilken nywilken added backport/website Backport PR changes to `stable-website` and latest release branch docs labels May 10, 2022

@nywilken nywilken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this further. Please let us know if we should communicate different process/instructions to maintainers.

@zchsh

zchsh commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

@nywilken Thank you! 💖

I think the docs are great as-is - for huaweicloud/packer-plugin-huaweicloud, I believe this might tie back to a previously valid 0.4.0 release on which seems to have since been deleted (with the version before, 0.3.0, not having docs at the repo root, as detailed in the docs).

For ivoronin/packer-plugin-sshkey, I think this ties to our lack of flexibility on the platform side in smart fallbacks when a docs.zip asset is missing, but docs is at the repo root. This latter case is one we're hoping to better handle via hashicorp/web-platform-packages#47 ☺️

@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/website Backport PR changes to `stable-website` and latest release branch docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants