fix(grpc): Ping should check health response status - #406
Closed
AruneshDwivedi wants to merge 1 commit into
Closed
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The GRPCClient.Ping method only checks transport error on health check, but ignores the response status. A plugin returning NOT_SERVING would appear healthy from the client perspective. Fix: capture HealthCheckResponse, verify Status == SERVING. Add test confirming NOT_SERVING triggers Ping() error.
Author
|
Closing in favor of #377 which addresses the same issue. Thanks @alliasgher! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341
The GRPCClient.Ping method only checks for transport errors when calling the gRPC health check, but ignores the response status. This means a plugin returning NOT_SERVING would appear healthy from the client perspective.
Changes:
Note: There is already an open PR (#377) by another contributor with a similar fix. This PR provides the same functional improvement with a regression test.