feat: Add streaming object download to S3Client#26
Merged
Conversation
jsync-swirlds
previously approved these changes
Apr 9, 2026
Nana-EC
previously approved these changes
May 5, 2026
d732654 to
cdc6209
Compare
Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>
Signed-off-by: Ivan St. Ivanov <ivan.st.ivanov@gmail.com>
a6cfa1a to
4b6bae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends S3Client with a new public methods to support streaming downloads: an S3 object is exposed directly as an InputStream without buffering it in memory. Returns null if the object does not exist
Related issue(s):
Fixes #25
Notes for reviewer:
The returned InputStream from openObjectStream is backed by a live HTTP connection — callers must close it (ideally via try-with-resources) to avoid connection leaks.