fix: handle uploadfile multipart abort on failure#19
Open
Nana-EC wants to merge 4 commits into
Open
Conversation
uploadFile() had no error handling after createMultipartUpload(). Any exception thrown during part upload or completeMultipartUpload() left the upload ID stranded in S3, accruing storage charges until manually aborted. Wrap the upload body in a try/catch that calls abortMultipartUpload() before re-throwing. Any exception from the abort itself is attached as a suppressed exception so the original cause is not lost. Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
force-pushed
the
12-uploadfile-multipart-abort-on-failure
branch
from
577eeb5 to
fb08c3a
Compare
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
uploadFile() had no error handling after createMultipartUpload(). Any exception thrown during part upload or completeMultipartUpload() left the upload ID stranded in S3, accruing storage charges until manually aborted.
Related issue(s):
Fixes #12
Notes for reviewer:
Checklist