Revert "Update the global ip pool (#1056)" - #1100
Merged
Merged
Conversation
This reverts commit e27cb74. Signed-off-by: Jian Wang <jian.wang@suse.com>
|
martindekov
approved these changes
Aug 7, 2026
martindekov
left a comment
martindekov
left a comment
Member
There was a problem hiding this comment.
As per offline discussion - to revert and add fresh PR documenting the limitations
|
Tick the box to add this pull request to the merge queue (same as
|
Member
Author
|
The known limitations of globl ip pool will be reworked, hence we merge this revert PR first. Will request more reviews upon the coming new PR, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e27cb74.
Problem:
Two code PRs upon the global pool has been reverted via harvester/load-balancer-harvester#194, hence we revert the paired doc PR #1056 as well.
Solution:
After this PR is merged, I will file another doc PR to book the limitation on harvester/load-balancer-harvester#194 (comment)
Related Issue(s):
harvester/harvester#10592
Test plan:
Not required.
Additional documentation or context