Update cloud provider with all new features of 0.2.12 - #1078
Open
w13915984028 wants to merge 4 commits into
Open
Update cloud provider with all new features of 0.2.12#1078w13915984028 wants to merge 4 commits into
w13915984028 wants to merge 4 commits into
Conversation
23 tasks
|
w13915984028
force-pushed
the
hcp0212
branch
3 times, most recently
from
August 14, 2026 12:57
dd9b17c to
3f5c0c8
Compare
w13915984028
changed the title
w13915984028
force-pushed
the
hcp0212
branch
4 times, most recently
from
August 14, 2026 15:40
002079b to
b67d15a
Compare
w13915984028
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Harvester Cloud Provider documentation to reflect newer functionality and configuration options (notably around v0.2.12), expanding guidance for deployment, cloud-config handling, extraArgs, and node metadata behavior.
Changes:
- Added an expanded introduction and “Main Functionalities” section describing CCM/HCP capabilities.
- Added detailed Helm chart configuration guidance (Rancher UI options, cloud-config via Secret, extraArgs examples, kube-vip behavior).
- Added a new “Node Instance Metadata Support” section explaining ProviderID/topology/address reporting.
Suppressed comments (3)
docs/rancher/cloud-provider.md:166
- This sentence refers to
secretNamewithout thecloudConfig.prefix, but the rest of the doc uses fully-qualified chart values (for example,cloudConfig.secretName). Using the full key here avoids ambiguity.
Maintained as a deprecation placeholder. This is only evaluated if `secretName` is empty and `cloudConfigPath` is removed.
docs/rancher/cloud-provider.md:596
- The PR title/throughout this doc references v0.2.12, but this K3s HelmChart example pins
harvester-cloud-providerto 0.2.15. This is inconsistent and may confuse readers about which version the instructions apply to.
version: 0.2.15
docs/rancher/cloud-provider.md:279
- This link points to
#node-metadata-reporting, but there is no corresponding heading/anchor in this document, so the link will be broken. It looks like it should point to the new "Node Instance Metadata Support" section.
- **Recommendation**: Leave this enabled (`false`) to ensure dynamic topology sync works seamlessly as detailed in [Node Metadata Reporting](#node-metadata-reporting).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
w13915984028
commented
Aug 14, 2026
|
|
||
| :::note | ||
|
|
||
| Please note a known backward compatibility issue if you're using the Harvester cloud provider version **v0.2.2** or higher. If your Harvester version is below **v1.2.0** and you intend to use newer RKE2 versions (i.e., >= `v1.26.6+rke2r1`, `v1.25.11+rke2r1`, `v1.24.15+rke2r1`), it is essential to upgrade your Harvester cluster to v1.2.0 or a higher version before proceeding with the upgrade of the guest Kubernetes cluster or Harvester cloud provider. |
Member
Author
There was a problem hiding this comment.
this block of content is outdated, hence remove it
Signed-off-by: Jian Wang <jian.wang@suse.com>
Signed-off-by: Jian Wang <jian.wang@suse.com>
Signed-off-by: Jian Wang <jian.wang@suse.com>
Signed-off-by: Jian Wang <jian.wang@suse.com>
Member
Author
|
The updated PR is ready for review now, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
After many PRs upon harvester/harvester#10068 are merged, a couple of new features are added to HCP, we need to update the document accordingly.
Solution:
Update the document.
Details are on #1078 (review)
Related Issue(s):
harvester/harvester#10068
Test plan:
Additional documentation or context