ci: add macos-26 build job for metal compute shaders#7
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @bniladridas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's continuous integration capabilities by integrating GitHub Actions' new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
✅ SPDX check passed — all changed files include the required license header. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to add a CI job for macOS on Apple Silicon. The changes include adding a .yamllint.yml configuration and updating the README.md. My review focuses on the correctness of the documentation and the maintainability of the new configuration file. I've identified a likely typo in the macOS runner name in the README.md which could cause the new CI job to fail. I've also provided feedback on the .yamllint.yml file, suggesting to re-enable some of the disabled linting rules to ensure YAML file quality and consistency across the project.
| - **Local CI**: Use `act` for GitHub Actions simulation, `gitlab-ci-local` for GitLab CI, or CircleCI local CLI. | ||
|
|
||
| > **⚠️ Important:** GitHub's hosted macOS runners are Intel-based and do not support Metal compute shaders. Full build and test must be performed locally on Apple Silicon hardware or using dedicated macOS runners (e.g., via GitLab CI). Only linting and syncing run on GitHub's hosted runners. | ||
| > **Note:** GitHub's hosted macOS-26 runners run natively on Apple Silicon and support Metal compute shaders. Full build and test can run on GitHub Actions using `macos-26`. |
There was a problem hiding this comment.
The runner label macos-26 appears to be incorrect. The official GitHub Actions runner with Apple Silicon support is macos-14. Using macos-26 will likely cause the workflow to fail. Please verify the runner label and update it here and in your workflow file.
| > **Note:** GitHub's hosted macOS-26 runners run natively on Apple Silicon and support Metal compute shaders. Full build and test can run on GitHub Actions using `macos-26`. | |
| > **Note:** GitHub's hosted macOS-14 runners run natively on Apple Silicon and support Metal compute shaders. Full build and test can run on GitHub Actions using `macos-14`. |
| rules: | ||
| document-start: disable | ||
| truthy: disable | ||
| line-length: disable | ||
| indentation: disable | ||
| brackets: disable |
There was a problem hiding this comment.
Disabling several fundamental yamllint rules, especially indentation, is concerning for future maintainability. While some rules like line-length can be a matter of preference, disabling rules for indentation and truthiness checks can lead to inconsistent and error-prone YAML files. It's generally better to fix the YAML files to conform to the linter's standards rather than disabling the checks. Please consider re-enabling most of these rules, particularly indentation and truthy, to maintain code quality.
|
✅ SPDX check passed — all changed files include the required license header. |
2 participants
Summary (refreshed):
macos-26build job to the GitHub Actions workflow for Swift compilation and tests..yamllint.ymlfile with relaxed document-formatting rules.