Retarget Harp.Generators to net8.0 - #140
Merged
Merged
Conversation
The package now ships lib/net8.0 in place of lib/netstandard2.0, and T4.BuildTools is marked PrivateAssets="all" so it no longer reaches the consumer graph, leaving Bonsai.Harp and YamlDotNet as the only declared dependencies. Eight nullable warnings raised by the annotated net8.0 BCL are cleared at the call sites for Dictionary.TryGetValue, object.ToString and MethodInfo.Invoke. A direction key holding a non-string now reports the invalid value rather than raising InvalidCastException. Closes harp-tech#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harp.Generatorsnow targetsnet8.0and shipslib/net8.0in place oflib/netstandard2.0.T4.BuildToolsis markedPrivateAssets="all", so the packed dependency group carries onlyBonsai.HarpandYamlDotNet, where 0.7.0 also carried build tooling that ships nolibfolder and that no consumer referenced.Eight nullable warnings come with the retarget, since the netstandard2.0 reference assemblies are null-oblivious while the net8.0 ones are annotated. All eight sit at the boundary with three BCL signatures,
Dictionary<TKey, TValue>.TryGetValue,object.ToStringandMethodInfo.Invoke, and each is cleared at the call site.Closes #139