Fix firmware sample and document core generation - #137
Merged
Conversation
The firmware usage sample deserialized into a PortPinMetadata type that does not exist, and now uses the Dictionary<string, PortPinInfo> the generator takes. Generating from metadata that declares no device name is documented on IsApplicationDevice and InterfaceGenerator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firmware usage sample in the package readme deserializes into a
PortPinMetadatatype that does not exist, so it would not compile. That name is a T4 template parameter, declared inAppRegs.ttasDictionary<string, PortPinInfo>, and the sample has carried it since v0.5.0. It now names the typeFirmwareGeneratoractually takes.Generating from metadata that declares no device name gains remarks on
DeviceMetadata.IsApplicationDevicefor the register classes and the address map, and onInterfaceGeneratorfor the absent asynchronous interface.Documentation only, so no generated output changes and no reference outputs move.