CI hygiene: drop dead env, bump actions, cache pip, enforce ruff#134
Open
SaInekK wants to merge 5 commits into
Open
CI hygiene: drop dead env, bump actions, cache pip, enforce ruff#134SaInekK wants to merge 5 commits into
SaInekK wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five small CI/import fixes, one commit each:
HARMONY_LITE=no_transformersfromtest.ymlanddocker.yml. PerCLAUDE.md, this env var is set but never read in code — the real switches areHARMONY_NO_PARSING/HARMONY_NO_MATCHING. CI was running the full stack regardless of this var; dropping it removes a misleading signal without changing what CI exercises.actions/checkout@v2 → v4andactions/setup-python@v2 → v5intest.yml.docker.ymlalready uses v4. v2 emits deprecation warnings on each run.cache: 'pip'withcache-dependency-path: pyproject.tomlto the setup-python step. Torch and transformers are heavy wheels — caching saves significant time per run.[tool.ruff]inpyproject.toml, pyflakes-only) but no step ran it. Addingruff check src testsbefore tox ensures the config stays useful.print()withwarnings.warn(..., ImportWarning)insrc/harmony/__init__.pyfor the "transformers not available" path. Library code shouldn't write to stdout;ImportWarningis the standard signal.All changes are mechanical and zero-risk to test behaviour. Verified locally that
import harmonystill works (both full andHARMONY_NO_MATCHING=1modes), andruff check src testspasses against the current config.