Repository navigation
Conversation
Claude Code retries a failed API request itself (dropped connection, rate limit, overload) and prints system/api_retry for each attempt. The adapter dropped those lines, so a network outage looked like a turn that froze on "working" for minutes. Show one keyed status row naming the cause and the attempt, updated in place, and remove it once the request produces output, the turn ends, the session stops, or the process exits.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: showing Claude Code API retries as a status row during retries. Description check The description includes the required What changed, Why, UI, and Checklist sections. It also documents validation results and confirms that the PR is focused. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
🧪 Generate unit tests (beta)
-
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #852 (one of the ways a long turn looks stuck).
What changed
apiRetryStatusTextinclaudeProtocol.tsmaps Claude Code'ssystem/api_retryline to a short status:Connection error · retrying (7/10)…,API overloaded · …,Rate limited · …,No response from the API · …orAPI error 500 · ….claude-api-retry), so each retry updates the same row instead of adding new ones, and removes the row as soon as the request produces output, the turn ends, the session stops, or the process exits. It uses the existing keyed-status support inapply.ts, where empty text removes the row.Why
When an API request fails, Claude Code retries it on its own (up to
max_retries, with backoff) and reports every attempt on stdout as{"type":"system","subtype":"api_retry","attempt":7,"max_retries":10,"error_status":null,…}. The adapter ignored these lines, so a dropped connection or an overloaded API showed nothing but the "working" timer for minutes, which looks the same as a hung turn. That is part of what #852 describes ("working vs stuck is impossible to tell"). The Claude Code terminal shows these retries; this shows them in the session too.UI
One system row in the turn while retries are happening, for example
Connection error · retrying (2/10)…. It updates in place and disappears once the reply starts streaming. Nothing changes when there are no retries.Validation
apiRetryStatusTextcases inclaudeProtocol.test.ts, and aclaudeLive.test.tscase where two retries are followed by output. It checks that the row is shown, updated, and then cleared exactly once. All three fail onmain.npm run check:web: vitest (5287 passed, 13 skipped) andtsc --noEmit. No Rust changes.Checklist
npm run check(check:web; no Rust files changed)Summary by CodeRabbit