Repository navigation
Conversation
When switching providers, the outgoing agent is asked for a recap. If that turn fails (the account lost access, a usage limit, the CLI exiting), the provider often streams its error as assistant text first, and that text became the brief the incoming agent received. Treat a turn that reported session.error or usage.limited, or threw, as failed and return nothing, so the caller falls back to the deterministic recap built from the transcript.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: preventing failed outgoing-turn errors from being used as the handoff recap. Description check The description includes all required sections, explains the change and reason, documents UI impact, records validation, and completes the checklist. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
🧪 Generate unit tests (beta)
-
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
requestOutgoingHandoffreturns an empty recap when the outgoing turn fails: it reportedsession.errororusage.limited, orsendHarnessTurnthrew. The caller (chooseHandoffBrief) then uses the deterministic recap built from the transcript, which is what the existingcatchcomment already intended.Why
When a session switches providers, the outgoing agent is asked to write the recap. If that turn fails, providers often stream the error as assistant text before failing, e.g. Claude Code with "Your organization has disabled Claude subscription access for Claude Code".
requestOutgoingHandoffkept whatevermessage.deltatext it had collected, and since such a message is longer thanMIN_AGENT_BRIEF,chooseHandoffBriefused it as the brief. The incoming agent then received the outgoing provider's error message instead of a summary of the conversation. The same applied to partial text from a turn that threw midway.UI
No layout changes. After a failed outgoing recap, the handoff card shows the transcript-based recap instead of the provider's error text.
Validation
handoffTurn.test.ts: a streamed recap is returned; an error streamed as assistant text followed bysession.erroryields""; partial text from a turn that throws yields"". The last two fail onmain.npm run check:web: vitest (5287 passed, 13 skipped) andtsc --noEmit. No Rust changes.Checklist
npm run check(check:web; no Rust files changed)Summary by CodeRabbit