Skip to content

fix(ratewise): MoneyBox history 檔名改用首爾時區 SSOT #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s123104 wants to merge 1 commit into from
Closed

fix(ratewise): MoneyBox history 檔名改用首爾時區 SSOT #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-moneybox-history-seoul-date.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@app/ratewise': patch
---

MoneyBox 歷史匯率快照檔名改以首爾時區日曆日命名，避免 UTC+9 換日窗口趨勢日期錯標
2 changes: 1 addition & 1 deletion .github/workflows/update-moneybox-rates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
id: save-history
if: steps.fetch-rates.outcome == 'success'
run: |
CURRENT_DATE=$(TZ=Asia/Taipei date +%Y-%m-%d)
CURRENT_DATE=$(TZ=Asia/Seoul date +%Y-%m-%d)
MONEYBOX_HISTORY_FILE="${MONEYBOX_HISTORY_DIR}/${CURRENT_DATE}.json"
mkdir -p "$MONEYBOX_HISTORY_DIR"
if [[ ! -f "$MONEYBOX_FETCH_OUTPUT_FILE" ]]; then
Expand Down
3 changes: 3 additions & 0 deletions apps/ratewise/src/config/__tests__/build-scripts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,9 @@ describe('ratewise build scripts', () => {
expect(workflowSource).toContain(
'MONEYBOX_HISTORY_FILE="${MONEYBOX_HISTORY_DIR}/${CURRENT_DATE}.json"',
);
// SSOT：MoneyBox 為首爾換匯所，history 檔名須對齊 Asia/Seoul 日曆日（非 Asia/Taipei）
expect(workflowSource).toContain('CURRENT_DATE=$(TZ=Asia/Seoul date +%Y-%m-%d)');
expect(workflowSource).not.toContain('CURRENT_DATE=$(TZ=Asia/Taipei date +%Y-%m-%d)');
expect(workflowSource).toContain('cp "$MONEYBOX_FETCH_OUTPUT_FILE" "$MONEYBOX_HISTORY_FILE"');
expect(workflowSource).not.toContain(
'cp "$MONEYBOX_FETCH_OUTPUT_FILE" "$MONEYBOX_LATEST_FILE"',
Expand Down
7 changes: 6 additions & 1 deletion docs/dev/002_development_reward_penalty_log.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

> 版本：outline-v2-ultra
> 原則：每筆只保留日期、ID、原因、解法。
> 本次分數變化：+1（reward 1、penalty 0）｜累計總分：前次總分 +59
> 本次分數變化：+1（reward 1、penalty 0）｜累計總分：前次總分 +60

## 新增模板（4 行）

Expand All @@ -13,6 +13,11 @@

## 條目（新→舊）

- 日期：2026-06-26
- ID：fix-moneybox-history-seoul-date-ssot
- 原因：MoneyBox workflow 以 Asia/Taipei 產生 history 檔名，首爾午夜換日但台北仍前一日時會錯標 30 日 aggregate 日期
- 解法：update-moneybox-rates.yml 改以 Asia/Seoul 對齊 fetch-moneybox-rates.js SSOT，並補 build-scripts 守門測試

- 日期：2026-06-26
- ID：reward-ci-e2e-full-shard-timeout-45
- 原因：main push E2E Full 2-way shard 仍設 20 分鐘逾時，完整 desktop+mobile 套件在冷快取下被取消，merge-reports 連帶失敗
Expand Down
Loading