[feat] Add MiniMax-H3 disaggregated inference across two DGX Sparks - #1830
Open
Satyam-53 wants to merge 4 commits into
Open
[feat] Add MiniMax-H3 disaggregated inference across two DGX Sparks#1830Satyam-53 wants to merge 4 commits into
Satyam-53 wants to merge 4 commits into
Conversation
Contributor
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enable MiniMax-H3 inference across two DGX Sparks by keeping the encoder and VAEs resident on one machine and the DiT on the other. This distributes model memory across the pair and avoids repeated component loading between stages.
Add payload and timing diagnostics to identify how much latency comes from computation versus inter-node handoffs.
Changes
FASTVIDEO_H3_PROFILE_TRANSFERS=1, separating producer wait, object fetch, tensor materialization, and encode/denoise/decode time.FASTVIDEO_FA4to both actors before attention imports, log worker environments, and report actual backend import failures. Preserve VSA for the main H3 transformer.Test Plan
CPU regression tests in the
fastvideoconda environment:Targeted pre-commit checks:
Also verified FA4 environment propagation with real local Ray actors, including an already initialized Ray instance, explicit runtime-environment overrides, and inherited uploaded job code.
Manual generation on the Spark pair used the local three-request script with transfer profiling enabled:
The generation run used
FastVideo/FastVideo-FastH3-4-step-Preview-v1-VSA-DataFree, with 832×480 output, 124 frames, and 5 inference steps.Test Results
Test output and generation measurements
CPU regression output:
Targeted pre-commit checks passed. The CUDA selector change also passed its targeted pre-commit checks.
Local Ray smoke-test output:
All three manual Spark requests completed and saved videos:
Receive time includes Ray object fetching and tensor materialization, excluding producer wait. These measurements are not pure network wire time or a measured speedup against single-machine execution.
The generation measurements precede the final FA4 propagation fix. Full generation with FA4 and SSIM regression validation remain unverified.
Checklist
pre-commit run --all-filesand fixed all issuesFor model/pipeline changes, also check: